[clang] [clang][Diagnostics] Highlight code snippets (PR #66514)

[Erich Keane via cfe-commits]

Timm =?utf-8?q?Bäder?= <tbaeder at redhat.com>
Message-ID:
In-Reply-To: <llvm/llvm-project/pull/66514/clang at github.com>


erichkeane wrote:

This is a really great idea!  I like the direction this is going!  I think we need to find some way to get the source colors/have them be configurable.  Is there some sort of 'source' of terminal coloring that we could use?  Or a theme of some sort?  

At minimum, we need to let these colors be configurable in some way.  Is there some sort of prior art in another tool we can copy from?  Additionally, this needs to be disabled/disable-able via a command line switch eventually (as we do for our other coloring).  It should perhaps be a separate disable switch from how we highlight 'error' or 'warning', but enabled at the same time?

WDYT?

https://github.com/llvm/llvm-project/pull/66514