[PATCH] D153132: [clang analysis][NFCI] Preparatory work for D153131.

Mon Sep 18 13:15:22 PDT 2023

aaronpuchert added a comment.

In D153132#4431627 <https://reviews.llvm.org/D153132#4431627>, @courbet wrote:

>> Is this actually required for the subsequent change? I don't see the connection.
>
> In the followup change, we have to check the returns after the enter and exit CFG block are computed. We can't analyze the returns as they are seen because , because what matters for the returns is the locks that are live at the end of the function, not those that are live at the point where the `return` happens.

Is this still the case? Or do we not need this anymore.

> From a design perspective I think it might actually make more sens for them to be in the analyzer as `warnIfMutexNotHeld` and friends actually inspects quite a lot of the `Analyzer` state.

On that I agree.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153132/new/

https://reviews.llvm.org/D153132