[PATCH] D64087: [clang] Correct source locations for instantiations of out-of-line defaulted special member functions. (PR25683)

Corentin Jabot via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Sep 18 09:28:19 PDT 2023


cor3ntin accepted this revision.
cor3ntin added a comment.

1 nit but still LGTM



================
Comment at: clang/lib/Sema/SemaTemplateInstantiateDecl.cpp:4993
 
-  // Copy the inner loc start from the pattern.
+  // Copy source locations from the pattern.
+  Function->setLocation(PatternDecl->getLocation());
----------------



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64087/new/

https://reviews.llvm.org/D64087



More information about the cfe-commits mailing list