[PATCH] D134654: [clang] Detect header loops

Nathan Sidwell via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Sep 18 06:28:26 PDT 2023


urnathan added a comment.

In D134654#4645969 <https://reviews.llvm.org/D134654#4645969>, @cor3ntin wrote:

> @aaron.ballman @urnathan What is the status of this PR?

I'd kind of forgotten about it. Did get a query from, I think, boost about how I detected the loops  I reported -- which was by hacking the compiler and a bit of scripting.  But it seems there might be users desiring the knowledge of this.

And personally I noticed that if you write your headers as:

  #ifndef MACRO
  // body of header goes here
  #define MACRO
  #endif // MACRO

the current technology shouts at you -- pity that idiom is not a thing :(


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134654/new/

https://reviews.llvm.org/D134654



More information about the cfe-commits mailing list