[PATCH] D152279: [Driver] Default -msmall-data-limit= to 0

Sat Sep 16 16:22:09 PDT 2023

MaskRay added a comment.

In D152279#4638173 <https://reviews.llvm.org/D152279#4638173>, @asb wrote:

> In D152279#4612099 <https://reviews.llvm.org/D152279#4612099>, @craig.topper wrote:
>
>> In D152279#4612087 <https://reviews.llvm.org/D152279#4612087>, @MaskRay wrote:
>>
>>> I am still interested in moving this forward. What should be done here? If the decision is to keep the current odd default 8 for `toolchains::RISCVToolChain`, I guess I'll have to take the compromise as making a step forward is better than nothing.
>>
>> On 1 RV64 CPU I tried in our RTL simulator, changing from 8 to 0 reduced dhrystone score by 2.7%. Using 16, or 32 gave the same score as 8. Reducing 8 to 4 improved the score by 0.5%.
>
> Thanks for testing - do you have a view one way or another on this default? I'm somewhat torn personally.

Is this patch blocked by anything?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D152279/new/

https://reviews.llvm.org/D152279