[clang] [libc++] Prevent calling the projection more than three times (PR #66315)
via cfe-commits
cfe-commits at lists.llvm.org
Fri Sep 15 16:13:52 PDT 2023
================
@@ -37,9 +37,10 @@ struct __fn {
_LIBCPP_ASSERT_UNCATEGORIZED(!bool(std::invoke(__comp, std::invoke(__proj, __high), std::invoke(__proj, __low))),
"Bad bounds passed to std::ranges::clamp");
- if (std::invoke(__comp, std::invoke(__proj, __value), std::invoke(__proj, __low)))
+ auto&& __projected = std::invoke(__proj, __value);
+ if (std::invoke(__comp, std::forward<decltype(__projected)>(__projected), std::invoke(__proj, __low)))
return __low;
- else if (std::invoke(__comp, std::invoke(__proj, __high), std::invoke(__proj, __value)))
+ else if (std::invoke(__comp, std::invoke(__proj, __high), std::forward<decltype(__projected)>(__projected))
----------------
timsong-cpp wrote:
https://github.com/microsoft/STL/issues/3970#issuecomment-1685120958
https://github.com/llvm/llvm-project/pull/66315
More information about the cfe-commits
mailing list