[PATCH] D159522: [Clang][C] Fixed a bug where we reject an _Atomic qualified integer in a switch statment

Aaron Ballman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Sep 15 10:27:26 PDT 2023


aaron.ballman added a comment.

Thank you for working on this! You should also add a release note for the fix.



================
Comment at: clang/lib/Sema/SemaOverload.cpp:6306-6310
+  ExprResult Converted = DefaultLvalueConversion(From);
+  QualType T = Converted.isUsable() ? Converted.get()->getType() : QualType();
   // If the expression already has a matching type, we're golden.
-  QualType T = From->getType();
   if (Converter.match(T))
     return DefaultLvalueConversion(From);
----------------
I think this is a slightly cleaner version of what you were doing.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D159522/new/

https://reviews.llvm.org/D159522



More information about the cfe-commits mailing list