[PATCH] D152504: [clang][ThreadSafety] Analyze cleanup functions

Aaron Puchert via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Sep 14 16:47:02 PDT 2023


aaronpuchert accepted this revision.
aaronpuchert added inline comments.
This revision is now accepted and ready to land.


================
Comment at: clang/lib/Analysis/ThreadSafety.cpp:1776
 /// \param D     The callee declaration.
 /// \param Self  If \p Exp = nullptr, the implicit this argument.
 /// \param Loc   If \p Exp = nullptr, the location.
----------------
aaronpuchert wrote:
> We should relax this like "the implicit this argument or the argument to an implicitly called cleanup function".
Would be nice if you could also adapt the comment as stated.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D152504/new/

https://reviews.llvm.org/D152504



More information about the cfe-commits mailing list