[PATCH] D69062: Resolve LWG issue 2426

Eric Fiselier via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Sep 14 13:43:49 PDT 2023


EricWF commandeered this revision.
EricWF edited reviewers, added: zoecarver; removed: EricWF.
EricWF added a comment.
Herald added a reviewer: libc++.
Herald added a project: All.

In D69062#1711610 <https://reviews.llvm.org/D69062#1711610>, @ldionne wrote:

> If we want to mark the LWG issue as being resolved for libc++, I think the test should be moved to the libc++ test suite. Otherwise, we're only assessing that libc++ implements LWG2426 __on Clang__.

I don't agree. Clang implements this behavior, the fact that C++ chose to put std::atomic in the library rather than the language has more to do with C++ and less to do with implementation responsibility.
If making changes to libc++ won't change the output of this test, then having the test doesn't matter.

I've marked the LWG issue as complete in a separate commit, and I'm going to close this now.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69062/new/

https://reviews.llvm.org/D69062



More information about the cfe-commits mailing list