[PATCH] D158413: [Lex] Introduce Preprocessor::LexAll()

Vassil Vassilev via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Sep 14 01:58:14 PDT 2023


v.g.vassilev added inline comments.


================
Comment at: clang/lib/Lex/Preprocessor.cpp:998
 
+std::vector<Token> Preprocessor::LexAll() {
+  std::vector<Token> toks;
----------------
Shouldn't we take the results as a `LexAll(std::vector<Token> &result)`?

Perhaps we should rename this interface to `LexTokensUntilEOF`?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158413/new/

https://reviews.llvm.org/D158413



More information about the cfe-commits mailing list