[clang] Update GoogleTest to v1.14.0 (PR #65823)

via cfe-commits cfe-commits at lists.llvm.org
Thu Sep 14 01:17:06 PDT 2023


mikaelholmen wrote:

I see compilation problems with this patch.
By mistake I originally posted about the problems in
https://github.com/llvm/llvm-project/issues/66268#issuecomment-1718791073

So the problem: On a RHEL7 server we see stuff like:
`
In file included from /repo/uabelho/dev-main/compiler-rt/lib/memprof/tests/driver.cpp:9:
In file included from /repo/uabelho/dev-main/runtimes/../third-party/unittest/googletest/include/gtest/gtest.h:65:
In file included from /repo/uabelho/dev-main/runtimes/../third-party/unittest/googletest/include/gtest/gtest-death-test.h:43:
In file included from /repo/uabelho/dev-main/runtimes/../third-party/unittest/googletest/include/gtest/internal/gtest-death-test-internal.h:47:
/repo/uabelho/dev-main/runtimes/../third-party/unittest/googletest/include/gtest/gtest-matchers.h:728:50: error: too few template arguments for class template 'equal_to'
  728 |       : ComparisonBase<EqMatcher<Rhs>, Rhs, std::equal_to<>>(rhs) {}
      |                                                  ^
/usr/lib/gcc/x86_64-redhat-linux/4.8.5/../../../../include/c++/4.8.5/bits/stl_function.h:204:12: note: template is declared here
  203 |   template<typename _Tp>
      |   ~~~~~~~~~~~~~~~~~~~~~~
  204 |     struct equal_to : public binary_function<_Tp, _Tp, bool>
      |            ^
`
so it looks like it's when it's using the newly built clang to compile 
 compiler-rt/lib/memprof/tests/driver.cpp
it's using header files from the host and those headers are too old for the updated GoogleTest.

If we don't build builtins (LLVM_BUILTIN_TARGETS) I don't see any problems.




https://github.com/llvm/llvm-project/pull/65823


More information about the cfe-commits mailing list