[PATCH] D158169: [X86] Fix i128 argument passing under SysV ABI

Nikita Popov via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Sep 14 00:36:16 PDT 2023


nikic added a comment.

In D158169#4645012 <https://reviews.llvm.org/D158169#4645012>, @RalfJung wrote:

>> I think the CCIfSplit means it was larger than i64 to start.
>
> What about the case where `R9` would take the *second* half of a split i128 (i.e., the value gets split across `R8` and `R9`)? Does that still work after this patch?

Yes, this is the case tested in `@in_reg`. `CCIfSplit` only matches the first part of a split value, not all parts of it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158169/new/

https://reviews.llvm.org/D158169



More information about the cfe-commits mailing list