[PATCH] D147218: [OpenMP][Flang][MLIR] Lowering of OpenMP requires directive from parse tree to MLIR

Kiran Chandramohan via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Sep 13 04:29:53 PDT 2023


kiranchandramohan added a comment.

In D147218#4645055 <https://reviews.llvm.org/D147218#4645055>, @skatrak wrote:

> Thank you for the review. After I address your last comment my plan is to land this and the other two accepted REQUIRES patches that depended on it.
>
> Is there a preferred approach as to how to go about it? I could rebase them all and wait until the pre-merge builds finish without errors and then land them in quick succession or I could go one by one to make sure post-merge builds don't find any issues before landing the next, which will be over a couple of days most likely.

Both are fine. I would recommend the former.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D147218/new/

https://reviews.llvm.org/D147218



More information about the cfe-commits mailing list