[clang] ca8d253 - [clang-repl][Orc] Export executable symbols in ClangReplInterpreterExceptionTests

Kai Luo via cfe-commits cfe-commits at lists.llvm.org
Tue Sep 12 22:24:25 PDT 2023


Author: Kai Luo
Date: 2023-09-13T05:24:20Z
New Revision: ca8d2533c79ccfbcb2de4090f0d48914a60b0a3d

URL: https://github.com/llvm/llvm-project/commit/ca8d2533c79ccfbcb2de4090f0d48914a60b0a3d
DIFF: https://github.com/llvm/llvm-project/commit/ca8d2533c79ccfbcb2de4090f0d48914a60b0a3d.diff

LOG: [clang-repl][Orc] Export executable symbols in ClangReplInterpreterExceptionTests

In Orc runtime, we use `dlopen(nullptr, ...)` to open current executable and use `dlsym` to find addresses of symbols, this requires `-rdynamic` flag.

As `llvm/CMakeLists.txt` suggests

```
# Make sure we don't get -rdynamic in every binary. For those that need it,
# use export_executable_symbols(target).
```
This patch exports symbols in `ClangReplInterpreterExceptionTests`. This also fixes `ClangReplInterpreterExceptionTests` is skipped on ppc64 when jitlink is used.

Reviewed By: v.g.vassilev

Differential Revision: https://reviews.llvm.org/D159167

Added: 
    

Modified: 
    clang/unittests/Interpreter/ExceptionTests/CMakeLists.txt

Removed: 
    


################################################################################
diff  --git a/clang/unittests/Interpreter/ExceptionTests/CMakeLists.txt b/clang/unittests/Interpreter/ExceptionTests/CMakeLists.txt
index 9f6ed2eb4fe7da0..5a6597d1b6728f9 100644
--- a/clang/unittests/Interpreter/ExceptionTests/CMakeLists.txt
+++ b/clang/unittests/Interpreter/ExceptionTests/CMakeLists.txt
@@ -22,3 +22,5 @@ target_link_libraries(ClangReplInterpreterExceptionTests PUBLIC
   clangFrontend
   )
 add_dependencies(ClangReplInterpreterExceptionTests clang-resource-headers)
+
+export_executable_symbols(ClangReplInterpreterExceptionTests)


        


More information about the cfe-commits mailing list