[PATCH] D155769: [HIP][Clang][docs][RFC] Add documentation for C++ Parallel Algorithm Offload

Tue Sep 12 17:06:59 PDT 2023

AlexVlx marked an inline comment as done.
AlexVlx added inline comments.

================
Comment at: clang/docs/HIPSupport.rst:216
+
+Given the following C++ code, which assumes the ``std`` namespace is included:
+
----------------
keryell wrote:
> Since this does not sounds like an official wording and this is not a recommended practice https://isocpp.org/wiki/faq/coding-standards#using-namespace-std, I suggest just adding `std::` everywhere since this is an end-user document.
> Further more it makes clear that your extension can work with the standard library instead of something that would be declared in a namespace from your extension.
> 
Addressed, thanks!

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155769/new/

https://reviews.llvm.org/D155769