[PATCH] D159103: [Driver][HLSL] Improve diagnostics for invalid shader model and stage
Justin Bogner via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Tue Sep 12 10:12:58 PDT 2023
bogner updated this revision to Diff 556589.
bogner added a comment.
Herald added a subscriber: pmatos.
- Check isSPIRVLogical rather than isSPIRV
- Improve diagnostics given that HLSL can generate both DXIL and SPIR-V
- Add tests for SPIR-V triples
- Fix missing `REQUIRES:` in dxil triple tests
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D159103/new/
https://reviews.llvm.org/D159103
Files:
clang/include/clang/Basic/DiagnosticDriverKinds.td
clang/lib/Frontend/CompilerInvocation.cpp
clang/lib/Sema/SemaDecl.cpp
clang/test/Driver/hlsl-lang-targets-spirv.hlsl
clang/test/Driver/hlsl-lang-targets.hlsl
llvm/include/llvm/TargetParser/Triple.h
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D159103.556589.patch
Type: text/x-patch
Size: 10453 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20230912/ae0db5bb/attachment.bin>
More information about the cfe-commits
mailing list