[clang] First batch of patches for the Juliet benchmark for taint improvements (PR #66074)

via cfe-commits cfe-commits at lists.llvm.org
Tue Sep 12 05:55:38 PDT 2023


================
@@ -105,7 +105,8 @@ bool isStdin(SVal Val, const ASTContext &ACtx) {
   if (const auto *D = dyn_cast_or_null<VarDecl>(DeclReg->getDecl())) {
     D = D->getCanonicalDecl();
     // FIXME: This should look for an exact match.
-    if (D->getName().contains("stdin") && D->isExternC()) {
+    if (D->getName().contains("stdin") && D->hasExternalStorage() &&
----------------
DonatNagyE wrote:

Could you change this to an exact match, following the FIXME above this line? Is there any reason for using "contains"?

https://github.com/llvm/llvm-project/pull/66074


More information about the cfe-commits mailing list