[PATCH] D127221: [Clang] Enable -print-pipeline-passes in clang.
Arthur Eubanks via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Mon Sep 11 13:33:34 PDT 2023
aeubanks added inline comments.
================
Comment at: clang/lib/CodeGen/BackendUtil.cpp:1102
+ outs() << "\n";
+ return;
+ }
----------------
I wouldn't return here, doesn't seem right that we'll skip running the opt pipeline but continue with compilation. we should either bail out entirely of producing any output files (which would probably require code changes elsewhere), or run everything as normal, not do something weird where we don't run the optimization pipeline but still output files
================
Comment at: clang/test/CodeGen/print-pipeline-passes.c:8
+// CHECK: always-inline
+// CHECK-SAME: BitcodeWriterPass
+void Foo(void) {}
----------------
I wouldn't test BitcodeWriterPass, we may have a proper textual name for it at some point
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D127221/new/
https://reviews.llvm.org/D127221
More information about the cfe-commits
mailing list