[PATCH] D159490: Fix warning in MSVC

Erich Keane via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Sep 11 07:16:07 PDT 2023


erichkeane added a comment.

In D159490#4643196 <https://reviews.llvm.org/D159490#4643196>, @giulianobelinassi wrote:

> In D159490#4643191 <https://reviews.llvm.org/D159490#4643191>, @fdeazeve wrote:
>
>> I think this may have broken builds:
>>
>>   worktrees/src1/clang/lib/AST/DeclPrinter.cpp:293:48: error: function definition is not allowed here
>>   static bool mustPrintOnLeftSide(const Attr *A) {
>>
>> Probably missing a `}`?
>
> No, there is just an extra switch statement that somehow got into the patch. I will fix this in a second.

Yikes, what I get for committing and not building first :)  I believe @giulianobelinassi still doesn't have commit access, so I'll just fix it as review-after-commit.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D159490/new/

https://reviews.llvm.org/D159490



More information about the cfe-commits mailing list