[PATCH] D151938: [clang][index] NFCI: Make `CXFile` a `FileEntryRef`

Sun Sep 10 10:03:05 PDT 2023

jansvoboda11 added a comment.

In D151938#4626992 <https://reviews.llvm.org/D151938#4626992>, @Jake-Egan wrote:

> Sorry for the late response @jansvoboda11, when `lookupModuleFile` is called, the file `build/tools/clang/test/Index/Core/Output/index-with-module.m.tmp.mcp/A03A61VI43WA/ModA-21USRMHJNU3PG.pcm` doesn't exist. So it seems there's some issue with the creation of the file.
>
> The backtrace is:
>
>   ...

@Jake-Egan Thank you for the stack trace and XFAILing the test! Other tests started failing after converting more `FileEntry` usages to `FileEntryRef`: https://lab.llvm.org/buildbot/#/builders/214/builds/9416

There are definitely some behavioral changes these patches introduce, but I don't see anything obviously wrong. What's more concerning, though, is that `llvm::expectedToOptional()`/`llvm::cantFail()` end up in `llvm_unreachable()`. Are you able to investigate? If not, could you provide me a way to reproduce this? These failures only occur on the AIX bots AFAIK.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D151938/new/

https://reviews.llvm.org/D151938