[PATCH] D152054: [OpenMP] Codegen support for thread_limit on target directive

[Kazushi Marukawa via Phabricator via cfe-commits]

kaz7 added a comment.

I cannot write inline comment, so I'm leaving message here.

openmp/runtime/test/target/target_thread_limit.cpp:

> // checking consecutive target regions with different thread_limits
> #pragma omp target thread_limit(3)
>
>   {
>     printf("\nsecond target: thread_limit = %d", omp_get_thread_limit());
>
> // OMP51: second target: thread_limit = 3

Our VE architecture supports only OpenMP runtime.  It doesn't support libomptarget.  If I run check-openmp on our machine, this omp_get_thread_limit() returns default thread limit 2147483647 (=0x7fffffff).  I guess it is OK because this pragma specifies only target and our VE doensn't support target.  Other pragmas are containing not only target but also other keyword like parallel, so I guess others are running well.  I'm not clear about omptarget, so my assumptions here may be wrong, though.

My question is what is the best way to correct the behavior of this test?  I appreciate any comments or suggestions.  Thank you!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D152054/new/

https://reviews.llvm.org/D152054