[PATCH] D158926: [clangd] Show parameter hints for operator()

Younan Zhang via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sat Sep 9 22:34:40 PDT 2023


zyounan marked 2 inline comments as done.
zyounan added inline comments.


================
Comment at: clang-tools-extra/clangd/InlayHints.cpp:626
+          Method && Method->isInstance())
+        Args = Args.drop_front(1);
+    processCall(Callee, Args);
----------------
nridge wrote:
> Huh, that's an interesting inconsistency between CXXMemberCallExpr and CXXOperatorCallExpr (that one include th implied object argument in getArgs() and the other doesn't)
> 
> As always, thank you for writing thorough tests that give us confidence we're doing the right thing :)
I'm glad to hear that! Thank you.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158926/new/

https://reviews.llvm.org/D158926



More information about the cfe-commits mailing list