[PATCH] D159414: [Driver] Fixes for header / library paths on Haiku

[Alex Brachet via Phabricator via cfe-commits]

abrachet added inline comments.


================
Comment at: clang/test/Driver/haiku.cpp:2
+// Check the C++ header path (libstdc++)
+// RUN: %clang++ --target=x86_64-unknown-haiku -### %s 2>&1 \
+// RUN:   --sysroot=%S/Inputs/haiku_x86_64_tree \
----------------
brad wrote:
> abrachet wrote:
> > This test is broken for people who configure with a different default `CLANG_DEFAULT_CXX_STDLIB`. I think this test should add `--stdlib=libstdc++`
> > This test is broken for people who configure with a different default `CLANG_DEFAULT_CXX_STDLIB`. I think this test should add `--stdlib=libstdc++`
> 
> Ah, I wasn't aware of that. I made the test such assuming the driver uses a default of libstdc++ on Haiku. I can add the flag.
I just made https://github.com/llvm/llvm-project/pull/65871, testing it now. But I think it should fix it


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D159414/new/

https://reviews.llvm.org/D159414