[PATCH] D159486: Fix build error in CI.
Zahira Ammarguellat via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Fri Sep 8 14:29:47 PDT 2023
zahiraam added a comment.
In D159486#4642305 <https://reviews.llvm.org/D159486#4642305>, @smeenai wrote:
> Generally it's preferred to either push bot failure fixes directly or revert the original commit (also without review), to get bots unblocked as soon as possible :)
>
> From what I can see, the test failure is because `dso_local` isn't emitted on Mac. That seems incidental to the point of your test, so using a regex match instead might be preferable.
Thanks. I am going to continue with a review since I started it. It should work now. Thanks for the suggestion (I always forget about RE and MAC :-).
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D159486/new/
https://reviews.llvm.org/D159486
More information about the cfe-commits
mailing list