[PATCH] D159115: [clang-repl] Adapt to the recent dylib-related changes in ORC.

Vassil Vassilev via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Sep 8 10:28:32 PDT 2023


v.g.vassilev added a subscriber: lkail.
v.g.vassilev added a comment.

In D159115#4642111 <https://reviews.llvm.org/D159115#4642111>, @tuliom wrote:

> In D159115#4641834 <https://reviews.llvm.org/D159115#4641834>, @mgorny wrote:
>
>> Is that actually a regression, or merely the test wasn't checking it before?
>
> I can't tell because the test didn't exist before.
>
>> My educated guess would be that the code in the test redefines `printf` without the header mangling, so it finds and compares the "non-IEEE" symbol against the "IEEE" symbol that's exposed to the test case via the headers.
>
> I agree with you.

Would that be a problem with the RuntimeDyld part of the JIT on ppc64le? Maybe @lkail could help us sort it out?

cc: @lhames


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D159115/new/

https://reviews.llvm.org/D159115



More information about the cfe-commits mailing list