[PATCH] D153152: Adds tweak to add declarations for pure virtuals

Robert Schneider via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Sep 8 10:20:35 PDT 2023


robot updated this revision to Diff 556283.
robot marked 3 inline comments as done.
robot added a comment.
Herald added a project: clang.

WIP - several improvements

I thought it might be a good idea to give an update even though this is
still work in progress.

- Don't print `virtual` for added declarations
- Some rework of the declaration generation
- Add title with preview
- Make tweak only available if it adds anything
- Mostly fix multiple inheritance
- Disable tweak on forward declarations


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153152/new/

https://reviews.llvm.org/D153152

Files:
  clang-tools-extra/clangd/AST.cpp
  clang-tools-extra/clangd/AST.h
  clang-tools-extra/clangd/Protocol.cpp
  clang-tools-extra/clangd/Protocol.h
  clang-tools-extra/clangd/refactor/tweaks/CMakeLists.txt
  clang-tools-extra/clangd/refactor/tweaks/DeclarePureVirtuals.cpp
  clang-tools-extra/clangd/unittests/CMakeLists.txt
  clang-tools-extra/clangd/unittests/TestTU.cpp
  clang-tools-extra/clangd/unittests/TestTU.h
  clang-tools-extra/clangd/unittests/tweaks/DeclarePureVirtualsTests.cpp
  clang-tools-extra/clangd/unittests/tweaks/TweakTesting.cpp
  clang-tools-extra/clangd/unittests/tweaks/TweakTesting.h
  clang/include/clang/AST/CXXInheritance.h
  clang/include/clang/AST/PrettyPrinter.h
  clang/lib/AST/TypePrinter.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D153152.556283.patch
Type: text/x-patch
Size: 56318 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20230908/ab04c529/attachment-0001.bin>


More information about the cfe-commits mailing list