[clang] [sema] Improve -Wsign-compare (PR #65684)

[Shafik Yaghmour via cfe-commits]

https://github.com/shafik commented:

Looks good overall, just the one side case I mentioned should be tested and mostly small nits.

https://github.com/llvm/llvm-project/pull/65684