[PATCH] D141375: [SYCL][OpenMP] Fix compilation errors for unsupported __bf16 intrinsics

[Artem Belevich via Phabricator via cfe-commits]

tra added inline comments.
Herald added a subscriber: jplehr.


================
Comment at: clang/lib/Sema/Sema.cpp:1978-1979
          !Context.getTargetInfo().hasInt128Type()) ||
+        (Ty->isBFloat16Type() && !Context.getTargetInfo().hasBFloat16Type() &&
+         !LangOpts.CUDAIsDevice) ||
         LongDoubleMismatched) {
----------------
@eandrews Do you recall what was the reason for *not* issuing the diagnostic on the GPU side?

It appears to do the opposite to what the patch description says. We're supposed to  `emit error for unsupported type __bf16 in device code`, but instead we specifically ignore it during GPU-side compilation. What am I missing?





Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141375/new/

https://reviews.llvm.org/D141375