[PATCH] D159483: [Modules] Add a flag to control builtin headers being in system modules

Ben Langmuir via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Sep 7 13:38:42 PDT 2023


benlangmuir added a comment.

>> How does this work today? Wouldn't the include guard prevent this?
>
> Today they don't define their include guard when building with modules.

Thanks - I can see some headers behave that way, or in other cases there are other sorts of has_feature(modules) checks that I can see you're modifying, but what about all the *va_* headers that currently just seem to have normal header guards?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D159483/new/

https://reviews.llvm.org/D159483



More information about the cfe-commits mailing list