[PATCH] D158474: [clang][ExtractAPI] Fix bool spelling coming from the macro definition.

Arthur Eubanks via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Sep 7 10:41:48 PDT 2023


aeubanks added inline comments.


================
Comment at: clang/test/ExtractAPI/bool.c:14
+//--- input.h
+#include <stdbool.h>
+bool Foo;
----------------
aeubanks wrote:
> clang tests should not be including system headers since that makes the tests non-hermetic (this test fails in our internal builds that provide more isolated test environments), could you make this not include <stdbool.h>?
ignore my previous comment, stdbool.h is provided by clang, sorry for the trouble


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158474/new/

https://reviews.llvm.org/D158474



More information about the cfe-commits mailing list