[clang-tools-extra] [lit] Are all RUN lines skipped in windows cmd? (PR #65242)

Paul T Robinson via cfe-commits cfe-commits at lists.llvm.org
Thu Sep 7 08:45:26 PDT 2023


pogo59 wrote:

I have no stake in Apple/Swift, but for myself, `cmd` is the natural shell to use on Windows. (When I install Visual Studio, it creates a widget that brings up a `cmd` shell with the right environment. I'm not aware of a similar widget for PowerShell.) While I rarely try to copy-paste from a `lit` dump into `cmd` (the commands are generally too full of long paths to temp locations to work well) I think it would be good (but not mandatory) for that copy-paste to actually work.

Like others have said, I had not really grokked that Windows defaults to the internal shell, although just this week I tripped over a behavioral difference in how `diff` works in the two environments (not related to your patches). So, if there seems to be benefit to making the external shell Just Not Work on Windows, I wouldn't lose a lot of sleep over it.

https://github.com/llvm/llvm-project/pull/65242


More information about the cfe-commits mailing list