[PATCH] D141714: Fix ast print of variables with attributes

Erich Keane via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Sep 7 08:22:13 PDT 2023


erichkeane added a comment.

In D141714#4640825 <https://reviews.llvm.org/D141714#4640825>, @giulianobelinassi wrote:

> In D141714#4638225 <https://reviews.llvm.org/D141714#4638225>, @erichkeane wrote:
>
>> Looks fine to me, please don't commit for a day or two to give @aaron.ballman a chance to make a final comment.
>
> I am sorry, but how am I supposed to commit those changes to main if I do not have write permission?

I didn't realize you didn't have commit permissions!  If you send me (either here, or privately) your name and email in the form of: "Full Name <email at ddr.com>"  I can do it for you


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141714/new/

https://reviews.llvm.org/D141714



More information about the cfe-commits mailing list