[PATCH] D156659: [clangd] Rollforward include-cleaner library usage in symbol collector.

[Kadir Cetinkaya via Phabricator via cfe-commits]

kadircet added inline comments.


================
Comment at: clang-tools-extra/clangd/index/SymbolCollector.cpp:828
-  tooling::stdlib::Lang Lang = tooling::stdlib::Lang::CXX;
-    if (LangOpts.C11)
-      Lang = tooling::stdlib::Lang::C;
----------------
sorry i got confused, this also works for ObjC, not just ObjC++. we set C-like features for ObjectiveC. can you just restore as-is?


================
Comment at: clang-tools-extra/clangd/index/SymbolCollector.cpp:919
+      if (IncludeHeader.empty())
+        HeaderFileURIs->getIncludeHeader(FID);
+
----------------
i guess LHS of the assignment got dropped by mistake?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156659/new/

https://reviews.llvm.org/D156659