[PATCH] D156659: [clangd] Rollforward include-cleaner library usage in symbol collector.

Kadir Cetinkaya via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Sep 7 04:52:44 PDT 2023


kadircet added inline comments.


================
Comment at: clang-tools-extra/clangd/index/SymbolCollector.cpp:912
+    if (Directives & Symbol::Import) {
+      if (auto IncludeHeader = HeaderFileURIs->getIncludeHeader(FID);
+          !IncludeHeader.empty()) {
----------------
VitaNuo wrote:
> kadircet wrote:
> > we should keep the `getStdHeaders` logic for objc
> `getStdHeaders` returns empty string for Obj-C, are you sure you meant it?
it reads a little bit weird, but it still actually works, for objective-c++ to be more specific. as we'll have `LangOpts.CPlusPlus` set for objc++


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156659/new/

https://reviews.llvm.org/D156659



More information about the cfe-commits mailing list