[PATCH] D158247: [CUDA][HIP] Fix overloading resolution in global variable initializer

Yaxun Liu via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Sep 7 04:48:06 PDT 2023


yaxunl reopened this revision.
yaxunl added a comment.
This revision is now accepted and ready to land.

The patch was reverted since it caused regressions on Windows for HIP. A reduced test case is:

  typedef void (__stdcall* funcTy)();
  void invoke(funcTy f);
  
  static void __stdcall callee() noexcept {
  }
  
  void foo() {
     invoke(callee);
  }

It is due to clang missed handling host/device attributes for calling convention at a few places.

Reopen to fix it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158247/new/

https://reviews.llvm.org/D158247



More information about the cfe-commits mailing list