[clang] [clang-format] Skip additional tests of the same case upon failure (PR #65540)

via cfe-commits cfe-commits at lists.llvm.org
Wed Sep 6 17:24:30 PDT 2023


owenca wrote:

Before:
```
.../llvm-project/clang/unittests/Format/FormatTestBase.h:93: Failure
Expected equality of these values:
  Expected.str()
    Which is: "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n    \"x\t\");"
  format(Code, Style, SC_ExpectComplete, Ranges)
    Which is: "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\"x\t\");"
With diff:
@@ -1,2 +1,1 @@
-aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(
-    \"x\t\");
+aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\"x\t\");

Google Test trace:
.../llvm-project/clang/unittests/Format/FormatTest.cpp:14824: aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(
    "x	");
.../llvm-project/clang/unittests/Format/FormatTestBase.h:102: Failure
Expected equality of these values:
  Expected.str()
    Which is: "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n    \"x\t\");"
  format(Code, ObjCStyle, SC_ExpectComplete, Ranges)
    Which is: "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\"x\t\");"
With diff:
@@ -1,2 +1,1 @@
-aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(
-    \"x\t\");
+aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\"x\t\");

Google Test trace:
.../llvm-project/clang/unittests/Format/FormatTest.cpp:14824: aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(
    "x	");
.../llvm-project/clang/unittests/Format/FormatTestBase.h:90: Failure
Expected equality of these values:
  Expected.str()
    Which is: "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n    \"x\t\");"
  format(Expected, Style, SC_ExpectComplete, Ranges)
    Which is: "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\"x\t\");"
With diff:
@@ -1,2 +1,1 @@
-aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(
-    \"x\t\");
+aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\"x\t\");

Expected code is not stable
Google Test trace:
.../llvm-project/clang/unittests/Format/FormatTest.cpp:14824: aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa( "x	");
```
After:
```
.../llvm-project/clang/unittests/Format/FormatTestBase.h:90: Failure
Expected equality of these values:
  ExpectedCode
    Which is: "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n    \"x\t\");"
  FormattedCode
    Which is: "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\"x\t\");"
With diff:
@@ -1,2 +1,1 @@
-aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(
-    \"x\t\");
+aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\"x\t\");

Google Test trace:
.../llvm-project/clang/unittests/Format/FormatTest.cpp:14824: aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(
```

https://github.com/llvm/llvm-project/pull/65540


More information about the cfe-commits mailing list