[PATCH] D159355: [clang][dataflow] Unsoundly treat "Unknown" as "Equivalent" in widening.

Wed Sep 6 09:59:40 PDT 2023

ymandel marked an inline comment as done.
ymandel added inline comments.

================
Comment at: clang/lib/Analysis/FlowSensitive/DataflowEnvironment.cpp:53
+//
+// FIXME: this function is a hook that enable unsoundness in support of
+// convergence. Once we have widening support for the reference/pointer and
----------------
mboehme wrote:
> Did you mean "hack"?
> 
> If you did indeed mean "hook" -- I think it's not strictly speaking a [hook](https://en.wikipedia.org/wiki/Hooking), as there's no way to change the behavior here (i.e. install a different handler). Maybe just "this function enables unsoundness..."?
yes, "hack". Good catch. :)

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D159355/new/

https://reviews.llvm.org/D159355