[PATCH] D152206: [Basic] Support 64-bit x86 target for UEFI

Brad Smith via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Sep 5 23:34:31 PDT 2023


brad added inline comments.


================
Comment at: clang/lib/Driver/ToolChains/UEFI.h:46
+  bool HasNativeLLVMSupport() const override { return true; }
+  bool IsIntegratedAssemblerDefault() const override { return true; }
+  bool IsUnwindTablesDefault(const llvm::opt::ArgList &Args) const {
----------------
You can remove the IsIntegratedAssemblerDefault line.


================
Comment at: clang/lib/Driver/ToolChains/UEFI.h:49
+    return true;
+  }
+  bool isPICDefault() const override { return true; }
----------------
This changed to UnwindTableLevel.

https://github.com/llvm/llvm-project/commit/4388b56d525c08ce3cf941cfbad2428b0e1695b0


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D152206/new/

https://reviews.llvm.org/D152206



More information about the cfe-commits mailing list