[PATCH] D155978: [SPIRV] Add SPIR-V logical triple.

Michal Paszkowski via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Sep 5 16:35:49 PDT 2023


mpaszkowski accepted this revision.
mpaszkowski added a comment.
This revision is now accepted and ready to land.

@Keenuts Hi Nathan, thanks for the patch! I agree with your approach and I think that this solution despite being a "hack" seems to be the most straightforward. Eventual differences could be handled in the backend. I would be open for other solutions in the future (for example in case other targets would also stumble upon a similar dilemma), but this looks like a completely valid approach to me.

@Anastasia Thanks for your input on this thread! I tried reaching out to you, but I realized you may no longer have access to the email address.

LGTM!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155978/new/

https://reviews.llvm.org/D155978



More information about the cfe-commits mailing list