[PATCH] D158963: [CodeGen] Function multi-versioning: don't set comdat for internal linkage resolvers

[Fangrui Song via Phabricator via cfe-commits]

MaskRay added inline comments.


================
Comment at: clang/docs/ReleaseNotes.rst:208
   (`#61334 <https://github.com/llvm/llvm-project/issues/61334>`_)
+- For function multi-versioning using the ``target`` or ``target_clones``
+  attributes, remove comdat for internal linkage functions.
----------------
ilinpv wrote:
> If I read the code right it applies for function multi-versioning using `target_version` and `target_clones` attributes ( AArch64 ) as well, doesn't it?
Yes, this patch fixed `target_version` as well.

Perhaps update_cc_test_checks.py should be updated to test comdat as well.

I'll adjust the release note to:

> For function multi-versioning using the ``target``, ``target_clones``, ``target_version`` ...


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158963/new/

https://reviews.llvm.org/D158963