[PATCH] D158540: Improve error message for constexpr constructors of virtual base classes

Tue Sep 5 10:45:56 PDT 2023

NoumanAmir657 added a comment.

In D158540#4632457 <https://reviews.llvm.org/D158540#4632457>, @NoumanAmir657 wrote:

> @aaron.ballman 
> This error gets generated on test cases even when a struct/class as no virtual base class.
> see this example on here: example <https://godbolt.org/z/47sYGjWxP>
>
> Is this right behaviour? The note for this should not be generated since this does not have a virtual base class.
>
> The example above is from a test case file in clang. The error message is the one which was supposed to be improved for this patch.
>
> Can you clarify this

@aaron.ballman waiting for your clarification on this to make the changes

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158540/new/

https://reviews.llvm.org/D158540