[clang] 3403686 - [Clang] Fix JIT test on 32-bit systems

Sam James via cfe-commits cfe-commits at lists.llvm.org
Tue Sep 5 08:04:33 PDT 2023


Author: Sam James
Date: 2023-09-05T16:04:22+01:00
New Revision: 3403686b72507e3fdbcd69f21fb9235ffa0ca169

URL: https://github.com/llvm/llvm-project/commit/3403686b72507e3fdbcd69f21fb9235ffa0ca169
DIFF: https://github.com/llvm/llvm-project/commit/3403686b72507e3fdbcd69f21fb9235ffa0ca169.diff

LOG: [Clang] Fix JIT test on 32-bit systems

As reported by mgorny at https://reviews.llvm.org/D159115#4638037, the
unsigned long long cast fails on 32-bit systems at least with GCC.

It looks like a pointer provenance/aliasing issue rather than a bug in GCC.

Acked by Vassil Vassilev on the original revision.

Added: 
    

Modified: 
    clang/unittests/Interpreter/InterpreterTest.cpp

Removed: 
    


################################################################################
diff  --git a/clang/unittests/Interpreter/InterpreterTest.cpp b/clang/unittests/Interpreter/InterpreterTest.cpp
index 07fb0028779ba0a..62e5bacbdd0b6d8 100644
--- a/clang/unittests/Interpreter/InterpreterTest.cpp
+++ b/clang/unittests/Interpreter/InterpreterTest.cpp
@@ -246,7 +246,7 @@ TEST(IncrementalProcessing, FindMangledNameSymbol) {
 
   // FIXME: Re-enable when we investigate the way we handle dllimports on Win.
 #ifndef _WIN32
-  EXPECT_EQ((unsigned long long)&printf, Addr->getValue());
+  EXPECT_EQ((uintptr_t)&printf, Addr->getValue());
 #endif // _WIN32
 }
 


        


More information about the cfe-commits mailing list