[PATCH] D159309: [ASTMatchers] basic matcher support for ConceptReference

Sam McCall via cfe-commits cfe-commits at lists.llvm.org
Mon Sep 4 04:42:52 PDT 2023


(by mail as phab is unusable today)

On Mon, Sep 4, 2023 at 10:16 AM Jens Massberg via Phabricator <
reviews at reviews.llvm.org> wrote:

> massberg added inline comments.
>
>
> ================
> Comment at: clang/docs/LibASTMatchersReference.html:2545
>    };
> -dependentSizedArrayType()
> +dependentSizedArrayType
>    matches "T data[Size]"
> ----------------
> Was this change to drop the () by purpose?
>
This file is generated, the source code is the source of truth.
Looks like 415d9e8ca39c0b42f351cc532ccfb48b6ac97f7f caused them to diverge
by editing the generated file only

I've fixed this in 3dcf3cbc421cb5ee985b3b4a697c51247df8b5dc


>
>
> ================
> Comment at: clang/docs/LibASTMatchersReference.html:2559
>    };
> -dependentSizedExtVectorType()
> +dependentSizedExtVectorType
>    matches "T __attribute__((ext_vector_type(Size)))"
> ----------------
> same as above
>
>
> Repository:
>   rG LLVM Github Monorepo
>
> CHANGES SINCE LAST ACTION
>   https://reviews.llvm.org/D159309/new/
>
> https://reviews.llvm.org/D159309
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20230904/287142c9/attachment.html>


More information about the cfe-commits mailing list