[PATCH] D158591: Add support of Windows Trace Logging macros
Richard Dzenis via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Mon Sep 4 03:22:40 PDT 2023
RIscRIpt added a comment.
In D158591#4636814 <https://reviews.llvm.org/D158591#4636814>, @cor3ntin wrote:
> Hum. before I do
>
> - I think the commit message could be more explicit as to what the patch does ("Add support of Windows Trace Logging macros" is a bit vague)
> - Do we need a release note ?
I agree that single commit message is vague. That's why I submitted two separate commits with detailed messages (the first one has some details in body).
I don't think we need release notes, because it's a bug fix.
P.S. I don't have access to PC until next week, I am okay if you adjust commit messages in a way you want.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D158591/new/
https://reviews.llvm.org/D158591
More information about the cfe-commits
mailing list