[clang] [clang][bpf] Fix invalid RUN lines in stack protector warning test (PR #65251)

David Spickett via cfe-commits cfe-commits at lists.llvm.org
Mon Sep 4 03:16:34 PDT 2023


https://github.com/DavidSpickett created https://github.com/llvm/llvm-project/pull/65251:

2 of them were missing the ":" on the end.

Adding them broke the test so I had to add a new prefix just for the warning runs only.

I manually checked the first RUNs and there is no warning emitted, as expected.

>From 5e23b30672dcdff137b97a193e4defd9cc177abc Mon Sep 17 00:00:00 2001
From: David Spickett <david.spickett at linaro.org>
Date: Fri, 1 Sep 2023 13:38:39 +0000
Subject: [PATCH] [clang][bpf] Fix invalid RUN lines in stack protector warning
 test

2 of them were missing the ":" on the end.

Adding them broke the test so I had to add a new prefix just for
the warning runs only.

I manually checked the first RUNs and there is no warning emitted,
as expected.
---
 clang/test/CodeGen/bpf-stack-protector.c | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/clang/test/CodeGen/bpf-stack-protector.c b/clang/test/CodeGen/bpf-stack-protector.c
index c17af890eac239a..f79a49e6aa686df 100644
--- a/clang/test/CodeGen/bpf-stack-protector.c
+++ b/clang/test/CodeGen/bpf-stack-protector.c
@@ -1,16 +1,16 @@
 // REQUIRES: bpf-registered-target
 
-// RUN %clang -target bpf -S -emit-llvm -o - %s -fno-stack-protector 2>&1 \
-// RUN        | FileCheck -check-prefix=OFF -check-prefix=COMMON %s
+// RUN: %clang -target bpf -S -emit-llvm -o - %s -fno-stack-protector 2>&1 \
+// RUN:        | FileCheck -check-prefix=OFF -check-prefix=COMMON %s
 
 // RUN: %clang -target bpf -S -emit-llvm -o - %s -fstack-protector 2>&1 \
-// RUN:        | FileCheck -check-prefix=ON -check-prefix=COMMON %s
+// RUN:        | FileCheck -check-prefix=ON -check-prefix=COMMON -check-prefix=WARNING %s
 
 // RUN: %clang -target bpf -S -emit-llvm -o - %s -fstack-protector-all 2>&1 \
-// RUN:        | FileCheck -check-prefix=ALL -check-prefix=COMMON %s
+// RUN:        | FileCheck -check-prefix=ALL -check-prefix=COMMON -check-prefix=WARNING %s
 
 // RUN: %clang -target bpf -S -emit-llvm -o - %s -fstack-protector-strong 2>&1 \
-// RUN:        | FileCheck -check-prefix=STRONG -check-prefix=COMMON %s
+// RUN:        | FileCheck -check-prefix=STRONG -check-prefix=COMMON -check-prefix=WARNING %s
 
 typedef __SIZE_TYPE__ size_t;
 
@@ -22,7 +22,7 @@ char *strcpy(char *s1, const char *s2);
 //          ON: warning: ignoring '-fstack-protector'
 //         ALL: warning: ignoring '-fstack-protector-all'
 //      STRONG: warning: ignoring '-fstack-protector-strong'
-// COMMON-SAME: option as it is not currently supported for target 'bpf'
+// WARNING-SAME: option as it is not currently supported for target 'bpf'
 
 // COMMON: define {{.*}}void @test1(ptr noundef %{{[0-9a-z]+}}) #[[A:.*]] {
 void test1(const char *msg) {



More information about the cfe-commits mailing list