[PATCH] D159409: Haiku: Pick up a few more codegen parametres from downstream

Brad Smith via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sun Sep 3 01:30:36 PDT 2023


brad added a comment.





================
Comment at: clang/lib/Driver/ToolChains/Haiku.h:39
+
+  unsigned GetDefaultDwarfVersion() const override { return 2; }
+
----------------
nielx wrote:
> I propose pushing this to version 4. Haiku's GCC also defaults to version 4 now.
I was using the version utilized by the patchset from the LLVM pacakge in HaikuPorts.

```
+  if (!global_options_set.x_dwarf_version)
+    dwarf_version = 4;
```

It seems you're right. I think it should be bumped up as well.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D159409/new/

https://reviews.llvm.org/D159409



More information about the cfe-commits mailing list