[PATCH] D159174: [Clang] Use stable_sort in AppendTargetMangling

Piyou Chen via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Sep 1 21:26:21 PDT 2023


BeMg added a comment.

Thanks for the review.

I'm working on RISC-V FMV support, and we found the large set of extension features is hard to maintain the priority that doesn't collision at all.

Lack the appropriate priority, it will generate the random mangling name. The predictable mangling name is convenient for testing.

This goal could also be achieved by giving the serial number for each feature, but I think the stable sort approach is simpler.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D159174/new/

https://reviews.llvm.org/D159174



More information about the cfe-commits mailing list