[PATCH] D157810: [clang][ExtractAPI] Create extractapi::RecordLocation

Juergen Ributzka via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Sep 1 16:31:03 PDT 2023


ributzka added inline comments.


================
Comment at: clang/include/clang/ExtractAPI/API.h:141
+  unsigned Line, Col;
+  std::string Filename;
+
----------------
There is an opportunity for optimization by avoiding the allocation of separate strings for each source location, especially since many source locations will be in the same file. As an example, APISet utilizes a BumpPtrAllocator to allocate and deduplicate strings. It is recommended to consider using the same allocator or a similar concept.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D157810/new/

https://reviews.llvm.org/D157810



More information about the cfe-commits mailing list