[PATCH] D74094: Reapply: [IRGen] Emit lifetime intrinsics around temporary aggregate argument allocas

John McCall via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Sep 1 11:15:58 PDT 2023


rjmccall added a comment.

Parameter objects are not temporaries and have their own lifetime rules, so there's nothing wrong with this idea in principle.  This seems to just be a bug, probably that we're doing a type check on `E->getType()` without considering whether E might be a gl-value.  We definitely do not want to be emitting lifetime intrinsics for the referent of a reference argument just because the underlying type is an aggregate.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74094/new/

https://reviews.llvm.org/D74094



More information about the cfe-commits mailing list