[PATCH] D159312: [Headers] Remove a space in NULL define

Aaron Ballman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Sep 1 05:10:26 PDT 2023


aaron.ballman added a comment.

In D159312#4633989 <https://reviews.llvm.org/D159312#4633989>, @dalias wrote:

> I don't understand the motivation of trying to match musl's definition here. musl explicitly **does not support** using a compiler-provided `stddef.h` or other standard headers. If it's getting included, this is a symption of an include order problem that needs to be fixed, and getting an error telling you that is preferable.

Oh! Thank you for that information, that's really good to know! Our stddef.h is one of the few headers we provide that doesn't do an `include_next` to get to the system library header if one is available; I wonder if that's a contributing factor?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D159312/new/

https://reviews.llvm.org/D159312



More information about the cfe-commits mailing list